Compare commits

...

35 Commits

Author SHA1 Message Date
GitHub Actions
e5d941c460 Bump version to 2024.12.4 [skip-versioning] 2024-12-22 01:12:50 +00:00
Edward Firmo
9b134a786a Merge pull request #50 from edwardtfn/swipe-priority
Rebuild Button click engine
2024-12-22 02:12:39 +01:00
Edward Firmo
be0fc353f6 Simplify relay handler 2024-12-22 02:03:35 +01:00
Edward Firmo
fbc5cb79cc Reduce BUTTON_MULTI_CLICK_DELAY to 250ms 2024-12-22 01:46:28 +01:00
Edward Firmo
c65acc3298 Pass parameters to button_click_event 2024-12-22 01:37:07 +01:00
Edward Firmo
4d8107faf2 Remove relay from binary sensor 2024-12-22 01:15:26 +01:00
Edward Firmo
65bbd901b1 Clean-up get_button_from_position 2024-12-21 23:32:15 +01:00
Edward Firmo
8c610a406a Log long-press from component
If this works fine, it could replace this part on the new implementation.
2024-12-21 23:17:42 +01:00
Edward Firmo
696e3bf28d Component to provide button number 2024-12-21 23:10:16 +01:00
Edward Firmo
5ae4564e6a CodeRabbitAI Nitpick 2 2024-12-21 22:08:19 +01:00
Edward Firmo
857c43940d CodeRabbitAI Nitpick 2024-12-21 21:54:54 +01:00
Edward Firmo
8668fe8dc9 Fix another bad reference 2024-12-21 21:29:05 +01:00
Edward Firmo
976a903118 Fix references 2024-12-21 21:25:29 +01:00
Edward Firmo
35cc0c4a8e Reorganize scripts for better clarity 2024-12-21 21:18:54 +01:00
Edward Firmo
5c4581563e Rebuild Button click engine
The native engine from ESPHome cannot be used here as a button press event is triggered on touch, which would trigger the click even on swipe.
Other projects solved this by tracking only single click and only at release, so we decided to implement this in a different way, so we can handle multiple or long-clicks also.
This should finally solve #14, but some test is required to ensure nothing else was broken.
2024-12-21 21:14:41 +01:00
GitHub Actions
7f1c362a50 Bump version to 2024.12.3 [skip-versioning] 2024-12-21 17:09:47 +00:00
Edward Firmo
cf3018c95c Merge pull request #49 from edwardtfn/new-versioning-03
Fix verison validation
2024-12-21 18:09:37 +01:00
Edward Firmo
360ae3123a Update bump_version.sh 2024-12-21 18:06:00 +01:00
Edward Firmo
6767b5e765 Fix version validation 2024-12-21 18:00:46 +01:00
Edward Firmo
d5e5ebb3d6 Fix version format 2024-12-21 17:52:33 +01:00
Edward Firmo
46c04eb992 Merge pull request #46 from edwardtfn/new-versioning-03
Rollback to the last working point
2024-12-21 17:50:34 +01:00
Edward Firmo
8558bc3650 Merge branch 'main' into new-versioning-03 2024-12-21 17:49:58 +01:00
Edward Firmo
f32e2eee4f Add quotes around file path in cat command
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-12-21 17:14:00 +01:00
Edward Firmo
5a993165cd Rollback to the last working point 2024-12-21 14:54:47 +01:00
Edward Firmo
d04c2aff2f Merge pull request #45 from edwardtfn/new-versioning-02
Use an automation branch
2024-12-21 14:14:00 +01:00
Edward Firmo
2d79ee42c7 Quote variables and url 2024-12-21 14:05:37 +01:00
Edward Firmo
3f4fc7a505 Quote GitHub token in push command
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-12-21 13:55:26 +01:00
Edward Firmo
be23a5a0fd Quote variables in temporary branch creation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-12-21 13:54:51 +01:00
Edward Firmo
a23a2db352 Fix invalid YAML structure in push trigger
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-12-21 13:35:12 +01:00
Edward Firmo
4e73a11528 Use an automation branch 2024-12-21 13:27:58 +01:00
Edward Firmo
3c98d81bb7 Merge pull request #44 from edwardtfn/new-versioning-01
No leading zero on versions
2024-12-21 12:31:30 +01:00
Edward Firmo
e63447984d Remove duplicated version validation 2024-12-21 12:26:05 +01:00
Edward Firmo
1f1a8049e6 No leading zero on versions 2024-12-21 12:23:32 +01:00
Edward Firmo
0dddc0747b Merge pull request #43 from edwardtfn/test-new-versioning-04
Describe file
2024-12-21 11:55:06 +01:00
Edward Firmo
86d1513c6a Describe file 2024-12-21 11:54:42 +01:00
17 changed files with 325 additions and 261 deletions

View File

@@ -1,3 +1,11 @@
# This GitHub Actions workflow updates the "stable" and "latest" Git tags
# to point to the tag associated with a newly published release. It performs
# the following steps:
# 1. Checks out the repository code with full history.
# 2. Configures Git with a generic user for the action.
# 3. Moves and forcibly pushes the "stable" and "latest" tags to align with
# the tag of the newly published release.
# This ensures that "stable" and "latest" always point to the most recent release.
--- ---
name: Update Tags name: Update Tags

View File

@@ -1,11 +1,14 @@
# Workflow for managing versioning, tagging, and conditional updates # Workflow for managing versioning and tagging
--- ---
name: Bump Version and Tag name: Version Bump and Tag
on: # yamllint disable-line rule:truthy on: # yamllint disable-line rule:truthy
push: push:
branches: branches:
- main - main
paths-ignore:
- '**/VERSION'
- '**/VERSION_YAML'
workflow_dispatch: workflow_dispatch:
inputs: inputs:
update_stable: update_stable:
@@ -18,7 +21,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v4 - uses: "actions/checkout@v4"
- name: Set up Git - name: Set up Git
run: | run: |
@@ -27,19 +30,13 @@ jobs:
- name: Bump Version - name: Bump Version
run: | run: |
chmod +x ./versioning/bump_version.sh chmod +x "./versioning/bump_version.sh"
./versioning/bump_version.sh "./versioning/bump_version.sh"
- name: Push Changes and Tags - name: Push Changes and Tags
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
run: | run: |
git push https://x-access-token:${GITHUB_TOKEN}@github.com/edwardtfn/TX-Ultimate-Easy.git main git push "https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git" main
git push https://x-access-token:${GITHUB_TOKEN}@github.com/edwardtfn/TX-Ultimate-Easy.git --tags git push "https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git" --tags
- name: Conditionally Update Stable Tag
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.update_stable == 'true' }}
run: |
git tag -f stable
git push https://x-access-token:${GITHUB_TOKEN}@github.com/edwardtfn/TX-Ultimate-Easy.git stable --force
... ...

View File

@@ -1,6 +1,6 @@
--- ---
packages: packages:
basic_package: !include ../TX-Ultimate-Easy-ESPHome.yaml # Basic package basic_package: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml # Basic package
esp32: esp32:
framework: framework:

View File

@@ -1,6 +1,6 @@
--- ---
packages: packages:
basic_package: !include ../TX-Ultimate-Easy-ESPHome.yaml # Core package core_package: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
addon_bluetooth_proxy: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_addon_ble_proxy.yaml addon_bluetooth_proxy: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_addon_ble_proxy.yaml
esp32: esp32:

View File

@@ -1,5 +1,5 @@
--- ---
packages: packages:
basic_package: !include ../TX-Ultimate-Easy-ESPHome.yaml # Core package core_package: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
addon_bluetooth_proxy: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_addon_ble_proxy.yaml addon_bluetooth_proxy: !include ../ESPHome/TX-Ultimate-Easy-ESPHome_addon_ble_proxy.yaml
... ...

View File

@@ -74,7 +74,7 @@ improv_serial:
id: serial_improv id: serial_improv
logger: logger:
level: INFO level: DEBUG
ota: ota:
platform: esphome platform: esphome

View File

@@ -20,111 +20,53 @@ substitutions:
BUTTON_3_ACTION_TEXT: "Relay 3 (toggle)" BUTTON_3_ACTION_TEXT: "Relay 3 (toggle)"
BUTTON_4_ACTION_TEXT: "Relay 4 (toggle)" BUTTON_4_ACTION_TEXT: "Relay 4 (toggle)"
binary_sensor: BUTTON_CLICK_MIN_LENGTH: '50' # The minimum duration the click should last, in msec
- id: bs_button_1 BUTTON_CLICK_MAX_LENGTH: '350' # The maximum duration the click should last, in msec
name: Button 1 BUTTON_MULTI_CLICK_DELAY: '250' # The time to wait for another click, in msec
icon: mdi:gesture-tap-box BUTTON_PRESS_TIMEOUT: '10000' # Ignore if button is pressed for longer than this time, in msec
internal: false BUTTON_LONG_PRESS_DELAY: '800' # The time to wait to consider a long press, in msec
platform: template
on_click:
then:
- script.execute:
id: button_action
component: bs_button_1
event: click
on_double_click:
then:
- script.execute:
id: button_action
component: bs_button_1
event: double_click
on_multi_click:
- timing: &long_click-timing
- ON for at least 0.8s
invalid_cooldown: ${invalid_cooldown}
then:
- script.execute:
id: button_action
component: bs_button_1
event: long_click
- id: bs_button_2 binary_sensor:
- &binary_sensor_button_base
id: bs_button_2
name: Button 2 name: Button 2
icon: mdi:gesture-tap-box icon: mdi:gesture-tap-box
internal: true
platform: template platform: template
on_click: internal: true
then:
- script.execute:
id: button_action
component: bs_button_2
event: click
on_double_click:
then:
- script.execute:
id: button_action
component: bs_button_2
event: double_click
on_multi_click:
- timing: *long_click-timing
invalid_cooldown: ${invalid_cooldown}
then:
- script.execute:
id: button_action
component: bs_button_2
event: long_click
- id: bs_button_3 - id: bs_button_3
name: Button 3 name: Button 3
icon: mdi:gesture-tap-box <<: *binary_sensor_button_base
internal: true
platform: template
on_click:
then:
- script.execute:
id: button_action
component: bs_button_3
event: click
on_double_click:
then:
- script.execute:
id: button_action
component: bs_button_3
event: double_click
on_multi_click:
- timing: *long_click-timing
invalid_cooldown: ${invalid_cooldown}
then:
- script.execute:
id: button_action
component: bs_button_3
event: long_click
- id: bs_button_4 - id: bs_button_4
name: Button 4 name: Button 4
icon: mdi:gesture-tap-box <<: *binary_sensor_button_base
internal: true
platform: template - id: bs_button_1
on_click: name: Button 1
then: internal: false
- script.execute: <<: *binary_sensor_button_base
id: button_action
component: bs_button_4 globals:
event: click - id: button_press_button
on_double_click: type: uint8_t
then: restore_value: false
- script.execute: initial_value: '0'
id: button_action
component: bs_button_4 - id: button_press_position
event: double_click type: uint8_t
on_multi_click: restore_value: false
- timing: *long_click-timing initial_value: '0'
invalid_cooldown: ${invalid_cooldown}
then: - id: button_press_start_time
- script.execute: type: uint32_t
id: button_action restore_value: false
component: bs_button_4 initial_value: '0'
event: long_click
- id: click_counter
type: uint8_t
restore_value: false
initial_value: '0'
script: script:
- id: !extend boot_initialize - id: !extend boot_initialize
@@ -162,9 +104,31 @@ script:
parameters: parameters:
component: string component: string
event: string event: string
then: # There's nothing here so far then:
# Extended by: # Extended by:
# - core_api # - core_api
- lambda: |-
ESP_LOGI("core_hw_buttons", "Button '%s' action: '%s'", component.c_str(), event.c_str());
id(button_press_button) = 0;
id(click_counter) = 0;
id(button_press_start_time) = 0;
buttons_release->execute();
- id: button_click_event
mode: restart
parameters:
button_id: uint8_t
click_count: uint8_t
then:
- delay:
milliseconds: ${BUTTON_MULTI_CLICK_DELAY}
- lambda: |-
const std::string button_name = "bs_button_" + std::to_string(button_id);
std::string event_name;
if (click_count == 1) event_name = "click";
else if (click_count == 2) event_name = "double_click";
else event_name = std::to_string(click_count) + "_click";
button_action->execute(button_name.c_str(), event_name.c_str());
- id: buttons_release - id: buttons_release
mode: restart mode: restart
@@ -187,42 +151,78 @@ script:
then: then:
- script.execute: - script.execute:
id: touch_on_press_buttons id: touch_on_press_buttons
touch_x: !lambda return touch_x; touch_position: !lambda return touch_position;
- id: touch_on_press_buttons - id: touch_on_press_buttons
mode: restart mode: restart
parameters: parameters:
touch_x: uint8_t touch_position: uint8_t
then: then:
- lambda: |- - lambda: |-
id(button_press_start_time) = millis();
id(button_press_position) = touch_position;
uint8_t button = 0;
auto model_index = sl_tx_model_gang->active_index(); auto model_index = sl_tx_model_gang->active_index();
if (model_index.has_value()) { if (model_index.has_value()) {
uint8_t model_idx = model_index.value() + 1; const uint8_t model_idx = model_index.value() + 1; // Increment for 1-based indexing
switch (model_idx) { if (model_idx == 1) {
case 1: // 1 Gang button = 1; // Single button, always 1
bs_button_1->publish_state(true); } else {
break; const uint8_t width = ${TOUCH_POSITION_MAX_VALUE} / model_idx; // Width of each button region
case 2: // 2 Gang ESP_LOGV("core_hw_buttons", "Button regions: width=%" PRIu8 ", touch_position=%" PRIu8,
if (touch_x <= 5) bs_button_1->publish_state(true); width, touch_position);
else bs_button_2->publish_state(true); button = (touch_position / width) + 1; // Determine button region
break; if (button > model_idx)
case 3: // 3 Gang button = model_idx; // Clamp to max button count
if (touch_x <= 3) bs_button_1->publish_state(true); }
else if (touch_x <= 7) bs_button_2->publish_state(true); }
else bs_button_3->publish_state(true); // Update binary sensor
break; switch (button) {
case 4: // 4 Gang case 1:
if (touch_x <= 2) bs_button_1->publish_state(true); bs_button_1->publish_state(true);
else if (touch_x <= 5) bs_button_2->publish_state(true); break;
else if (touch_x <= 8) bs_button_3->publish_state(true); case 2:
else bs_button_4->publish_state(true); bs_button_2->publish_state(true);
break; break;
} case 3:
bs_button_3->publish_state(true);
break;
case 4:
bs_button_4->publish_state(true);
break;
}
// Update counters
if (id(button_press_button) == button) {
id(click_counter)++;
} else {
id(click_counter) = 1;
id(button_press_button) = button;
} }
- id: !extend touch_on_release - id: !extend touch_on_release
then: then:
- script.execute: buttons_release - lambda: |-
uint32_t current_time = millis();
buttons_release->execute();
if (id(button_press_start_time) > 0 and
id(button_press_start_time) < current_time) {
uint32_t press_duration = current_time - id(button_press_start_time);
// Handle overflow (optional, since it's unlikely to happen here)
ESP_LOGI("core_hw_buttons", "Button press duration: %" PRIu32 " ms", press_duration);
if (press_duration < ${BUTTON_CLICK_MIN_LENGTH}) {
ESP_LOGW("core_hw_buttons", "Ignoring button press (too short)");
} else if (press_duration >= ${BUTTON_CLICK_MIN_LENGTH} and
press_duration <= ${BUTTON_CLICK_MAX_LENGTH}) { // Short/normal click
button_click_event->execute(id(button_press_button), id(click_counter));
} else if (press_duration >= ${BUTTON_LONG_PRESS_DELAY} and press_duration <= ${BUTTON_PRESS_TIMEOUT}) {
button_action->execute(("bs_button_" + std::to_string(id(button_press_button))).c_str(), "long_click");
} else if (press_duration > ${BUTTON_PRESS_TIMEOUT}) { // Timeout or invalid
ESP_LOGW("core_hw_buttons", "Button press cancelled or timed out after ${BUTTON_PRESS_TIMEOUT} ms");
}
} else {
ESP_LOGW("core_hw_buttons", "Press event timestamp not recorded yet");
}
id(button_press_start_time) = 0;
- id: !extend touch_swipe_left - id: !extend touch_swipe_left
then: then:

View File

@@ -11,55 +11,6 @@
##### - For normal system use, modifications to this file are NOT required. ##### ##### - For normal system use, modifications to this file are NOT required. #####
#################################################################################################### ####################################################################################################
--- ---
binary_sensor:
- id: !extend bs_button_1
on_click:
then:
- if:
condition:
- lambda: return sl_button_1_action->active_index().has_value();
- lambda: return sl_button_1_action->active_index().value() == 1;
- and: &button_click_no_other_click
- lambda: return not bs_multi_touch->state;
- lambda: return not bs_swipe_left->state;
- lambda: return not bs_swipe_down->state;
- lambda: return not bs_swipe_right->state;
then:
- switch.toggle: sw_relay_1
- id: !extend bs_button_2
on_click:
then:
- if:
condition:
- lambda: return sl_button_2_action->active_index().has_value();
- lambda: return sl_button_2_action->active_index().value() == 1;
- and: *button_click_no_other_click
then:
- switch.toggle: sw_relay_2
- id: !extend bs_button_3
on_click:
then:
- if:
condition:
- lambda: return sl_button_3_action->active_index().has_value();
- lambda: return sl_button_3_action->active_index().value() == 1;
- and: *button_click_no_other_click
then:
- switch.toggle: sw_relay_3
- id: !extend bs_button_4
on_click:
then:
- if:
condition:
- lambda: return sl_button_4_action->active_index().has_value();
- lambda: return sl_button_4_action->active_index().value() == 1;
- and: *button_click_no_other_click
then:
- switch.toggle: sw_relay_4
globals: globals:
- id: boot_initialization_relays - id: boot_initialization_relays
type: bool type: bool
@@ -159,6 +110,45 @@ script:
} }
id(boot_initialization_relays) = true; id(boot_initialization_relays) = true;
- id: !extend button_click_event
then:
- lambda: |-
// Handle only single clicks
if (click_count != 1)
return;
// Ignore if other touch events are active
if (bs_multi_touch->state ||
bs_swipe_left->state ||
bs_swipe_down->state ||
bs_swipe_right->state) {
return;
}
// Toggle relay if corresponding button action is enabled
switch (button_id) {
case 1:
if (sl_button_1_action->active_index().has_value() and
sl_button_1_action->active_index().value() == 1)
sw_relay_1->toggle();
break;
case 2:
if (sl_button_2_action->active_index().has_value() and
sl_button_2_action->active_index().value() == 1)
sw_relay_2->toggle();
break;
case 3:
if (sl_button_3_action->active_index().has_value() and
sl_button_3_action->active_index().value() == 1)
sw_relay_3->toggle();
break;
case 4:
if (sl_button_4_action->active_index().has_value() and
sl_button_4_action->active_index().value() == 1)
sw_relay_4->toggle();
break;
}
- id: show_relay_status - id: show_relay_status
mode: restart mode: restart
then: then:

View File

@@ -11,6 +11,9 @@
##### - For normal system use, modifications to this file are NOT required. ##### ##### - For normal system use, modifications to this file are NOT required. #####
#################################################################################################### ####################################################################################################
--- ---
substitutions:
TOUCH_POSITION_MAX_VALUE: '10' # Maximum touch position value returned by the touch pad via uart
binary_sensor: binary_sensor:
- id: bs_multi_touch - id: bs_multi_touch
name: Multi-touch name: Multi-touch
@@ -61,7 +64,7 @@ external_components:
- source: - source:
type: git type: git
url: https://github.com/edwardtfn/TX-Ultimate-Easy url: https://github.com/edwardtfn/TX-Ultimate-Easy
ref: ${version} ref: v${version}
refresh: 1h refresh: 1h
components: components:
- tx_ultimate_easy - tx_ultimate_easy
@@ -124,7 +127,7 @@ script:
- id: touch_on_press - id: touch_on_press
mode: restart mode: restart
parameters: parameters:
touch_x: uint8_t touch_position: uint8_t
then: then:
# Extended by: # Extended by:
# - HW Buttons # - HW Buttons
@@ -203,16 +206,28 @@ tx_ultimate_easy:
id: tx_ultimate id: tx_ultimate
uart: uart_touch uart: uart_touch
on_long_touch_release:
- lambda: |-
const uint8_t touch_position = static_cast<uint8_t>(touch.x);
if (touch_position > ${TOUCH_POSITION_MAX_VALUE}) { // Check for valid range
ESP_LOGE("tx_ultimate_easy", "Invalid long-touch position: %" PRIu8, touch_position);
} else {
ESP_LOGI("tx_ultimate_easy", "Long-touch released at position %" PRIu8, touch_position);
}
on_multi_touch_release: on_multi_touch_release:
- lambda: ESP_LOGI("tx_ultimate_easy", "Multi-touch released"); - lambda: ESP_LOGI("tx_ultimate_easy", "Multi-touch released");
- script.execute: touch_on_multi_touch_release - script.execute: touch_on_multi_touch_release
on_press: on_press:
- lambda: |- - lambda: |-
ESP_LOGI("tx_ultimate_easy", "Pressed at position %" PRIu8, static_cast<uint8_t>(touch.x)); const uint8_t touch_position = static_cast<uint8_t>(touch.x);
- script.execute: if (touch_position > ${TOUCH_POSITION_MAX_VALUE}) { // Check for valid range
id: touch_on_press ESP_LOGE("tx_ultimate_easy", "Invalid touch position: %" PRIu8, touch_position);
touch_x: !lambda return static_cast<uint8_t>(touch.x); } else {
ESP_LOGI("tx_ultimate_easy", "Pressed at position %" PRIu8, touch_position);
touch_on_press->execute(touch_position);
}
on_release: on_release:
- lambda: ESP_LOGI("tx_ultimate_easy", "Released"); - lambda: ESP_LOGI("tx_ultimate_easy", "Released");
@@ -233,8 +248,8 @@ tx_ultimate_easy:
ESP_LOGD("tx_ultimate_easy", " Position: %i", touch.x); ESP_LOGD("tx_ultimate_easy", " Position: %i", touch.x);
uart: uart:
id: uart_touch - id: uart_touch
tx_pin: GPIO19 tx_pin: GPIO19
rx_pin: GPIO22 rx_pin: GPIO22
baud_rate: 115200 baud_rate: 115200
... ...

View File

@@ -16,7 +16,7 @@ wifi:
packages: packages:
remote_package: remote_package:
url: https://github.com/edwardtfn/TX-Ultimate-Easy url: https://github.com/edwardtfn/TX-Ultimate-Easy
ref: dev ref: latest
refresh: 30s refresh: 30s
files: files:
- ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml - ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml

View File

@@ -13,6 +13,7 @@ DEPENDENCIES = ['uart']
CONF_TX_ULTIMATE_EASY = "tx_ultimate_easy" CONF_TX_ULTIMATE_EASY = "tx_ultimate_easy"
CONF_UART = "uart" CONF_UART = "uart"
CONF_GANG_COUNT = "gang_count"
CONF_ON_TOUCH_EVENT = "on_touch_event" CONF_ON_TOUCH_EVENT = "on_touch_event"
CONF_ON_PRESS = "on_press" CONF_ON_PRESS = "on_press"
@@ -33,6 +34,7 @@ CONFIG_SCHEMA = cv.Schema({
cv.GenerateID(): cv.declare_id(TxUltimateTouch), cv.GenerateID(): cv.declare_id(TxUltimateTouch),
cv.Required(CONF_UART): cv.use_id(uart), cv.Required(CONF_UART): cv.use_id(uart),
cv.Optional(CONF_GANG_COUNT, default=1): cv.int_range(min=1, max=4),
cv.Optional(CONF_ON_TOUCH_EVENT): automation.validate_automation(single=True), cv.Optional(CONF_ON_TOUCH_EVENT): automation.validate_automation(single=True),
cv.Optional(CONF_ON_PRESS): automation.validate_automation(single=True), cv.Optional(CONF_ON_PRESS): automation.validate_automation(single=True),
@@ -49,6 +51,9 @@ async def register_tx_ultimate_easy(var, config):
uart_component = await cg.get_variable(config[CONF_UART]) uart_component = await cg.get_variable(config[CONF_UART])
cg.add(var.set_uart_component(uart_component)) cg.add(var.set_uart_component(uart_component))
if CONF_GANG_COUNT in config:
cg.add(var.set_gang_count(config[CONF_GANG_COUNT]))
if CONF_ON_TOUCH_EVENT in config: if CONF_ON_TOUCH_EVENT in config:
await automation.build_automation( await automation.build_automation(
var.get_trigger_touch_event(), var.get_trigger_touch_event(),

View File

@@ -48,6 +48,35 @@ namespace esphome {
void TxUltimateEasy::dump_config() { void TxUltimateEasy::dump_config() {
ESP_LOGCONFIG(TAG, "TX Ultimate Easy"); ESP_LOGCONFIG(TAG, "TX Ultimate Easy");
ESP_LOGCONFIG(TAG, " Gang count: %" PRIu8, this->gang_count_);
}
bool TxUltimateEasy::set_gang_count(const uint8_t gang_count) {
// Hardware supports maximum of 4 touch-sensitive buttons
if (gang_count < 1 or gang_count > 4)
return false;
this->gang_count_ = gang_count;
return true;
}
uint8_t TxUltimateEasy::get_button_from_position(const uint8_t position) {
// Validate position bounds
if (position > TOUCH_MAX_POSITION)
return 0;
// Special case for single gang (only one button exists)
if (this->gang_count_ == 1)
return 1;
// Calculate button number
const uint8_t width = (TOUCH_MAX_POSITION + 1) / this->gang_count_; // Width of each button region
if (width < 1 or width > this->gang_count_) // Invalid width - and prevents division by zero
return 0;
const uint8_t button = std::min(
static_cast<uint8_t>((position / width) + 1), // Convert position to button index
this->gang_count_ // Clamp to max gang count
);
return button;
} }
void TxUltimateEasy::send_touch_(TouchPoint tp) { void TxUltimateEasy::send_touch_(TouchPoint tp) {
@@ -103,7 +132,8 @@ namespace esphome {
state == TOUCH_STATE_SWIPE_LEFT || state == TOUCH_STATE_SWIPE_LEFT ||
state == TOUCH_STATE_SWIPE_RIGHT || state == TOUCH_STATE_SWIPE_RIGHT ||
state == TOUCH_STATE_MULTI_TOUCH) && state == TOUCH_STATE_MULTI_TOUCH) &&
(uart_received_bytes[6] >= 0 || state == TOUCH_STATE_MULTI_TOUCH); // Multi-touch events may have x < 0, all other events require valid x position
(uart_received_bytes[6] >= 0 || state == TOUCH_STATE_MULTI_TOUCH);
} }
int TxUltimateEasy::get_touch_position_x(const std::array<int, UART_RECEIVED_BYTES_SIZE> &uart_received_bytes) { int TxUltimateEasy::get_touch_position_x(const std::array<int, UART_RECEIVED_BYTES_SIZE> &uart_received_bytes) {
@@ -133,6 +163,8 @@ namespace esphome {
TouchPoint TxUltimateEasy::get_touch_point(const std::array<int, UART_RECEIVED_BYTES_SIZE> &uart_received_bytes) { TouchPoint TxUltimateEasy::get_touch_point(const std::array<int, UART_RECEIVED_BYTES_SIZE> &uart_received_bytes) {
TouchPoint tp; TouchPoint tp;
tp.x = this->get_touch_position_x(uart_received_bytes); tp.x = this->get_touch_position_x(uart_received_bytes);
if (tp.x >= 0)
tp.button = this->get_button_from_position(static_cast<uint8_t>(tp.x));
tp.state = this->get_touch_state(uart_received_bytes); tp.state = this->get_touch_state(uart_received_bytes);
switch (tp.state) { switch (tp.state) {
case TOUCH_STATE_RELEASE: case TOUCH_STATE_RELEASE:

View File

@@ -13,6 +13,9 @@
namespace esphome { namespace esphome {
namespace tx_ultimate_easy { namespace tx_ultimate_easy {
// Touch Max Position
constexpr uint8_t TOUCH_MAX_POSITION = 10;
// Touch State Constants // Touch State Constants
constexpr uint8_t TOUCH_STATE_RELEASE = 0x01; constexpr uint8_t TOUCH_STATE_RELEASE = 0x01;
constexpr uint8_t TOUCH_STATE_PRESS = 0x02; constexpr uint8_t TOUCH_STATE_PRESS = 0x02;
@@ -32,6 +35,7 @@ namespace esphome {
static const char *TAG = "tx_ultimate_easy"; static const char *TAG = "tx_ultimate_easy";
struct TouchPoint { struct TouchPoint {
uint8_t button = 0;
int8_t x = -1; int8_t x = -1;
int8_t state = -1; int8_t state = -1;
std::string state_str = "Unknown"; std::string state_str = "Unknown";
@@ -53,6 +57,10 @@ namespace esphome {
void loop() override; void loop() override;
void dump_config() override; void dump_config() override;
uint8_t get_gang_count() { return this->gang_count_; }
bool set_gang_count(const uint8_t gang_count);
uint8_t get_button_from_position(const uint8_t position);
protected: protected:
void send_touch_(TouchPoint tp); void send_touch_(TouchPoint tp);
void handle_touch(const std::array<int, UART_RECEIVED_BYTES_SIZE> &bytes); void handle_touch(const std::array<int, UART_RECEIVED_BYTES_SIZE> &bytes);
@@ -70,6 +78,8 @@ namespace esphome {
Trigger<TouchPoint> trigger_multi_touch_release_; Trigger<TouchPoint> trigger_multi_touch_release_;
Trigger<TouchPoint> trigger_long_touch_release_; Trigger<TouchPoint> trigger_long_touch_release_;
uint8_t gang_count_ = 1;
}; // class TxUltimateEasy }; // class TxUltimateEasy
} // namespace tx_ultimate_easy } // namespace tx_ultimate_easy

View File

@@ -1,35 +1,29 @@
# Versioning # Versioning
## Overview ## Overview
This project uses a time-based versioning scheme: `year.month.sequential_number`. This project uses a time-based versioning scheme: `year.month.sequential_number`.
This scheme makes it easy to identify when a version was released and provides a clear order for releases within a given month. The system automates version updates and tagging to ensure consistent, conflict-free management of releases.
### Examples ### Examples
- `2024.12.01` First release of December 2024. - `2024.1.1` First release of January 2024.
- `2024.12.02` Second release of December 2024. - `2024.12.2` Second release of December 2024.
- `2025.01.01` First release of January 2025.
## Files ## How It Works
- **`VERSION`**: Contains the current version of the project as plain text. 1. **Temporary Branch Creation**: A unique branch is created for each workflow run.
- **`bump_version.sh`**: A script to increment the version based on the current date and release sequence. 2. **Version Update**: The workflow updates the `VERSION` and `VERSION_YAML` files using the current date and release sequence.
- **`README.md`**: Documentation for the versioning process. 3. **Commit with Marker**: Changes are committed with a `[skip-versioning]` marker to prevent triggering the workflow again.
4. **Merge into Main**: The temporary branch is merged into `main`.
## Versioning Rules 5. **Branch Cleanup**: The temporary branch is deleted after merging.
1. The version format is `YYYY.MM.NN`, where:
- `YYYY` is the current year.
- `MM` is the current month (two digits).
- `NN` is the sequential release number within the month (starting at `01`).
2. On each new merge to the `main` branch:
- If the month hasnt changed, the sequential number (`NN`) is incremented.
- If the month has changed, the sequential number resets to `01`.
## Usage ## Usage
### Automatically Managed ### Automated Workflow
The versioning process is fully integrated into the workflow. Developers do not need to manually increment or manage versions. The versioning process is fully automated:
Simply push your changes, and the system will handle version updates and tagging automatically. - Developers submit their changes as usual.
- The workflow handles version updates, tagging, and integration into `main`.
- No manual intervention is needed for versioning.
### Access Version in Code ### Accessing the Version in Code
The version is accessible in the ESPHome YAML configuration file (`TX-Ultimate-Easy-ESPHome_core.yaml`) using the following syntax: The version is accessible in the ESPHome YAML configuration file (`TX-Ultimate-Easy-ESPHome_core.yaml`) using the following syntax:
```yaml ```yaml
@@ -37,30 +31,46 @@ substitutions:
version: <<: !include ../versioning/VERSION version: <<: !include ../versioning/VERSION
``` ```
This ensures the correct version is used directly in the ESPHome setup without requiring manual updates. This ensures the correct version is dynamically included in the ESPHome setup.
## Benefits of this Versioning Approach ## Benefits
1. **Clarity**: Each version is tied to a specific point in time, making it easy to track releases. - **Clarity**: Easily track when a release occurred with meaningful version numbers.
2. **Automation**: The process is seamless and reduces manual effort. - **Automation**: Eliminates manual version management.
3. **Scalability**: Supports frequent releases while keeping the versioning system organized. - **Scalability**: Supports frequent updates and concurrent workflows.
4. **Traceability**: Git tags and the `VERSION` file ensure releases are well-documented and easily accessible. - **Traceability**: Maintains a clear history of changes through Git tags and version files.
## System Details
### Version Format
The format `year.month.sequential_number` includes:
- `year` (YYYY): A 4-digit number representing the year.
- `month` (M): A number from 1 to 12 (no leading zeros).
- `sequential_number`: A positive number incremented with each release in the same month.
### Validation Rules
The `bump_version.sh` script enforces strict validation:
- Year must be a 4-digit number.
- Month must be 112 without leading zeros.
- Sequence must be a positive number without leading zeros.
If validation fails, the workflow stops and provides an error message.
### GitHub Workflow
The workflow is triggered automatically when:
- Changes are pushed to `main`.
- Developers trigger it manually using the `workflow_dispatch` event.
The workflow avoids infinite loops by committing changes with the `[skip-versioning]` marker.
## Extending the System ## Extending the System
- Add more scripts to handle additional automation tasks, such as generating changelogs or notifying stakeholders of new releases. Consider extending the system to:
- Enhance the `bump_version.sh` script to support different versioning schemes if needed. - Automatically generate release notes or changelogs.
- Integrate versioning information into your deployment pipelines to label builds with their corresponding version. - Notify stakeholders when a new version is released.
- Integrate versioning information into deployment pipelines.
## Version Validation ## FAQ
**Q: What happens if two workflows run concurrently?**
A: Each workflow operates in its own temporary branch, avoiding conflicts.
The versioning system enforces strict format validation: **Q: Can I manually update the version?**
- Year must be a 4-digit number (YYYY) A: Manual updates are not needed. The workflow ensures accurate, automated versioning.
- Month must be a 2-digit number (01-12)
- Sequence must be a 2-digit number (01-99)
The `bump_version.sh` script includes validation checks and will fail if:
- The version format is invalid
- The sequence number would exceed 99 in a month
### GitHub Actions Workflow Adjustment
The GitHub Actions workflow for versioning runs only when changes are merged into the `main` branch, ensuring no premature version updates during PR creation.
This behavior is automatically handled by the integrated workflow.

View File

@@ -1 +1 @@
2024.12.01 2024.12.4

View File

@@ -1 +1 @@
version: 2024.12.01 version: 2024.12.4

View File

@@ -5,18 +5,20 @@ VERSION_YAML_FILE="./versioning/VERSION_YAML"
# Read the current version # Read the current version
if [ -f "$VERSION_FILE" ]; then if [ -f "$VERSION_FILE" ]; then
CURRENT_VERSION=$(cat $VERSION_FILE) CURRENT_VERSION=$(cat "$VERSION_FILE")
else else
CURRENT_VERSION="0.0.0" # Default if file doesn't exist CURRENT_VERSION="0.0.0" # Default if file doesn't exist
fi fi
# Extract components # Validate the current version format
CURRENT_YEAR=$(date +%Y) if ! [[ "$CURRENT_VERSION" =~ ^[0-9]{4}\.[0-9]{1,2}\.[0-9]+$ ]]; then
CURRENT_MONTH=$(date +%m)
if ! [[ "$CURRENT_VERSION" =~ ^[0-9]{4}\.[0-9]{2}\.[0-9]{2}$ ]]; then
echo "Error: Invalid version format in $VERSION_FILE" echo "Error: Invalid version format in $VERSION_FILE"
exit 1 exit 1
fi fi
# Extract components
CURRENT_YEAR=$(date +%Y)
CURRENT_MONTH=$(date +%-m) # Avoid leading zero for the month
CURRENT_SEQ=$(echo "$CURRENT_VERSION" | awk -F. '{print $3}') CURRENT_SEQ=$(echo "$CURRENT_VERSION" | awk -F. '{print $3}')
VERSION_YEAR=$(echo "$CURRENT_VERSION" | awk -F. '{print $1}') VERSION_YEAR=$(echo "$CURRENT_VERSION" | awk -F. '{print $1}')
@@ -24,17 +26,12 @@ VERSION_MONTH=$(echo "$CURRENT_VERSION" | awk -F. '{print $2}')
# Determine new version # Determine new version
if [[ "$CURRENT_YEAR" == "$VERSION_YEAR" && "$CURRENT_MONTH" == "$VERSION_MONTH" ]]; then if [[ "$CURRENT_YEAR" == "$VERSION_YEAR" && "$CURRENT_MONTH" == "$VERSION_MONTH" ]]; then
NEXT_SEQ=$((10#$CURRENT_SEQ + 1)) NEXT_SEQ=$((CURRENT_SEQ + 1))
if [ $NEXT_SEQ -gt 99 ]; then
echo "Error: Sequence number would exceed 99"
exit 1
fi
NEW_SEQ=$(printf "%02d" $NEXT_SEQ)
else else
NEW_SEQ="01" # Reset sequence for a new month NEXT_SEQ=1 # Reset sequence for a new month
fi fi
NEW_VERSION="${CURRENT_YEAR}.${CURRENT_MONTH}.${NEW_SEQ}" NEW_VERSION="${CURRENT_YEAR}.${CURRENT_MONTH}.${NEXT_SEQ}"
# Update the plain text VERSION file # Update the plain text VERSION file
echo "$NEW_VERSION" > "$VERSION_FILE" echo "$NEW_VERSION" > "$VERSION_FILE"
@@ -47,7 +44,7 @@ if ! git add "$VERSION_FILE" "$VERSION_YAML_FILE"; then
echo "Error: Failed to stage version files" echo "Error: Failed to stage version files"
exit 1 exit 1
fi fi
if ! git commit -m "Bump version to $NEW_VERSION"; then if ! git commit -m "Bump version to $NEW_VERSION [skip-versioning]"; then
echo "Error: Failed to commit version bump" echo "Error: Failed to commit version bump"
exit 1 exit 1
fi fi