More CodeRabbitAI suggestions

This commit is contained in:
Edward Firmo
2024-12-19 23:52:21 +01:00
parent e9890c937e
commit 62e4e3d511
5 changed files with 16 additions and 0 deletions

View File

@@ -70,6 +70,7 @@ improv_serial:
id: serial_improv
logger:
level: INFO
ota:
platform: esphome

View File

@@ -20,6 +20,9 @@ api:
val: float
then:
- lambda: |-
ESP_LOGD("core_api", "Set float:");
ESP_LOGD("core_api", " Component: %s", component.c_str());
ESP_LOGD("core_api", " Value: %f", val);
if (!isnan(val)) {
if (component == "latitude" && val >= -90 && val <= 90) {
sun_entity->set_latitude(val);

View File

@@ -134,6 +134,10 @@ script:
- lambda: |-
const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
(sl_tx_model_gang->active_index().value() + 1) : 0;
if (num_gangs < 1 || num_gangs > 4) {
ESP_LOGE("hw_buttons", "Invalid number of gangs: %" PRIu8, num_gangs);
return;
}
bs_button_1->publish_state(false);
bs_button_1->set_internal(num_gangs < 1);
sl_button_1_action->set_internal(num_gangs < 1);

View File

@@ -760,6 +760,10 @@ script:
sl_tx_model_format->active_index().value() == 1;
const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
(sl_tx_model_gang->active_index().value() + 1) : 0;
if (num_gangs < 1 || num_gangs > 4) {
ESP_LOGE("hw_leds", "Invalid number of gangs: %" PRIu8, num_gangs);
return;
}
light_28->set_internal(!is_model_us);
light_29->set_internal(!is_model_us);
light_30->set_internal(!is_model_us);

View File

@@ -94,6 +94,10 @@ script:
sl_tx_model_format->active_index().value() == 1;
const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
(sl_tx_model_gang->active_index().value() + 1) : 0;
if (num_gangs < 1 || num_gangs > 4) {
ESP_LOGE("hw_relays", "Invalid number of gangs: %" PRIu8, num_gangs);
return;
}
sl_relay_1_mode->set_internal(num_gangs < 1);
sl_relay_1_light_mode_eu->set_internal(is_model_us or num_gangs < 1);
sl_relay_1_light_mode_us->set_internal(!is_model_us or num_gangs < 1);