From 62e4e3d511b02d2be523b14d3c1acf8c9d192bf3 Mon Sep 17 00:00:00 2001
From: Edward Firmo <94725493+edwardtfn@users.noreply.github.com>
Date: Thu, 19 Dec 2024 23:52:21 +0100
Subject: [PATCH] More CodeRabbitAI suggestions

---
 ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml            | 1 +
 ESPHome/TX-Ultimate-Easy-ESPHome_core_api.yaml        | 3 +++
 ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_buttons.yaml | 4 ++++
 ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_leds.yaml    | 4 ++++
 ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_relays.yaml  | 4 ++++
 5 files changed, 16 insertions(+)

diff --git a/ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml b/ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
index f407e5c..566bdd3 100644
--- a/ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
+++ b/ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
@@ -70,6 +70,7 @@ improv_serial:
   id: serial_improv
 
 logger:
+  level: INFO
 
 ota:
   platform: esphome
diff --git a/ESPHome/TX-Ultimate-Easy-ESPHome_core_api.yaml b/ESPHome/TX-Ultimate-Easy-ESPHome_core_api.yaml
index 6cc49f6..e99a892 100644
--- a/ESPHome/TX-Ultimate-Easy-ESPHome_core_api.yaml
+++ b/ESPHome/TX-Ultimate-Easy-ESPHome_core_api.yaml
@@ -20,6 +20,9 @@ api:
         val: float
       then:
         - lambda: |-
+            ESP_LOGD("core_api", "Set float:");
+            ESP_LOGD("core_api", "  Component: %s", component.c_str());
+            ESP_LOGD("core_api", "  Value:     %f", val);
             if (!isnan(val)) {
               if (component == "latitude" && val >= -90 && val <= 90) {
                 sun_entity->set_latitude(val);
diff --git a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_buttons.yaml b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_buttons.yaml
index e83804f..30667b2 100644
--- a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_buttons.yaml
+++ b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_buttons.yaml
@@ -134,6 +134,10 @@ script:
       - lambda: |-
           const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
                                     (sl_tx_model_gang->active_index().value() + 1) : 0;
+          if (num_gangs < 1 || num_gangs > 4) {
+            ESP_LOGE("hw_buttons", "Invalid number of gangs: %" PRIu8, num_gangs);
+            return;
+          }
           bs_button_1->publish_state(false);
           bs_button_1->set_internal(num_gangs < 1);
           sl_button_1_action->set_internal(num_gangs < 1);
diff --git a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_leds.yaml b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_leds.yaml
index 0d60d8e..e025ac8 100644
--- a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_leds.yaml
+++ b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_leds.yaml
@@ -760,6 +760,10 @@ script:
                                     sl_tx_model_format->active_index().value() == 1;
           const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
                                     (sl_tx_model_gang->active_index().value() + 1) : 0;
+          if (num_gangs < 1 || num_gangs > 4) {
+            ESP_LOGE("hw_leds", "Invalid number of gangs: %" PRIu8, num_gangs);
+            return;
+          }
           light_28->set_internal(!is_model_us);
           light_29->set_internal(!is_model_us);
           light_30->set_internal(!is_model_us);
diff --git a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_relays.yaml b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_relays.yaml
index dd3279c..0fe9c83 100644
--- a/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_relays.yaml
+++ b/ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_relays.yaml
@@ -94,6 +94,10 @@ script:
                                     sl_tx_model_format->active_index().value() == 1;
           const uint8_t num_gangs = (sl_tx_model_gang->active_index().has_value()) ?
                                     (sl_tx_model_gang->active_index().value() + 1) : 0;
+          if (num_gangs < 1 || num_gangs > 4) {
+            ESP_LOGE("hw_relays", "Invalid number of gangs: %" PRIu8, num_gangs);
+            return;
+          }
           sl_relay_1_mode->set_internal(num_gangs < 1);
           sl_relay_1_light_mode_eu->set_internal(is_model_us or num_gangs < 1);
           sl_relay_1_light_mode_us->set_internal(!is_model_us or num_gangs < 1);